Resubmit "[Parse] Implementation for SE-200 (raw strings)" #19170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnno1962
changed the title
|
@johnno1962 Could you amend a nicer commit message into this? In two years, nobody will care that this commit reverts a revert. Edit: Actually, I'll just change it when I squash it. Nevermind. |
|
@swift-ci please smoke test |
|
🥂Thanks @brentdax for all your help on this proposal. |
|
This seems to have broken the ASan bots because of accessing memory out of bounds https://bugs.swift.org/browse/SR-8724. I'm going to revert in #19214. The code in the lexer that's looking at -2 and -1 offsets into a string looks responsible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19168 to reinstate #17668 which missed a “squash” first time around.
Implementation for SE-200