Revert "SILOptimizer: make a conversion operation explicit" #19345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Bleh; reverting this breaks on Windows :-(. |
|
Yeah, sorry I don't have a better fix right now 😞 but I don't have this setup to reproduce and we need to prioritize keeping CI working. |
|
@benlangmuir - actually, I think I might have an idea - changing the forwarding constructor to copy construction might do it (aka, replacing the braces with parenthesis). Any idea of how to test that? |
|
@compnerd I don't know of a way to test 14.04 from a PR (CC @shahmishal in case I'm missing something). I'll try building your patch myself for now I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19300
This failed to build on Ubuntu 14.04:
https://ci.swift.org/job/oss-swift-package-linux-ubuntu-14_04/2187/
https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04-long-test/4947/
etc.