Skip to content

[Diagnostics] Port invalid reference to mutating member diagnostics to new framework #26014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 9, 2019
Merged

[Diagnostics] Port invalid reference to mutating member diagnostics to new framework #26014

merged 5 commits into from
Jul 9, 2019
+160 −148

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 9, 2019

Originally CSDiag had to guess whether this is a problem by trying to lookup member
name again and do ad-hoc argument to parameter matching, but new diagnostic framework
provides a more convenient way to archive this by introducing (disabled by default)
overload choice with associated fix, so solver could do the argument matching and
check whether member fits into larger expression.

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

/cc @sl

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please smoke test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2019

Build failed
Swift Test Linux Platform
Git Sha - 23d9722b2fc2069f8affa8c8147bc0d48848300c

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2019

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

Regressions found (see below)

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
time.swift-driver.wall 8.6s 8.4s -188.4ms -2.19% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 100,025,615,319 99,925,149,230 -100,466,089 -0.1%
LLVM.NumLLVMBytesOutput 6,167,136 6,167,136 0 0.0%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumLoadedModules 660 660 0 0.0%
AST.NumTotalClangImportedEntities 3,832 3,832 0 0.0%
IRModule.NumIRBasicBlocks 18,746 18,746 0 0.0%
IRModule.NumIRFunctions 10,616 10,616 0 0.0%
IRModule.NumIRGlobals 8,111 8,111 0 0.0%
IRModule.NumIRInsts 313,612 313,612 0 0.0%
IRModule.NumIRValueSymbols 17,790 17,790 0 0.0%
LLVM.NumLLVMBytesOutput 6,167,136 6,167,136 0 0.0%
SILModule.NumSILGenFunctions 5,372 5,372 0 0.0%
SILModule.NumSILOptFunctions 7,006 7,006 0 0.0%
Sema.NumConformancesDeserialized 13,773 13,773 0 0.0%
Sema.NumConstraintScopes 38,396 38,408 12 0.03%
Sema.NumDeclsDeserialized 115,216 115,216 0 0.0%
Sema.NumDeclsValidated 10,762 10,762 0 0.0%
Sema.NumFunctionsTypechecked 1,516 1,516 0 0.0%
Sema.NumGenericSignatureBuilders 4,249 4,249 0 0.0%
Sema.NumLazyGenericEnvironments 23,281 23,281 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 1,942 1,942 0 0.0%
Sema.NumLazyIterableDeclContexts 18,565 18,565 0 0.0%
Sema.NumTypesDeserialized 44,874 44,874 0 0.0%
Sema.NumTypesValidated 11,624 11,624 0 0.0%

Release

release brief

Regressed (1)
name old new delta delta_pct
time.swift-driver.wall 16.1s 16.3s 184.9ms 1.15% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 141,711,497,987 141,603,456,831 -108,041,156 -0.08%
LLVM.NumLLVMBytesOutput 7,189,332 7,189,316 -16 -0.0%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumLoadedModules 76 76 0 0.0%
AST.NumTotalClangImportedEntities 2,226 2,226 0 0.0%
IRModule.NumIRBasicBlocks 21,135 21,135 0 0.0%
IRModule.NumIRFunctions 10,104 10,104 0 0.0%
IRModule.NumIRGlobals 8,129 8,129 0 0.0%
IRModule.NumIRInsts 224,424 224,424 0 0.0%
IRModule.NumIRValueSymbols 17,407 17,407 0 0.0%
LLVM.NumLLVMBytesOutput 7,189,332 7,189,316 -16 -0.0%
SILModule.NumSILGenFunctions 4,178 4,178 0 0.0%
SILModule.NumSILOptFunctions 5,847 5,847 0 0.0%
Sema.NumConformancesDeserialized 12,323 12,323 0 0.0%
Sema.NumConstraintScopes 38,226 38,238 12 0.03%
Sema.NumDeclsDeserialized 31,871 31,871 0 0.0%
Sema.NumDeclsValidated 7,784 7,784 0 0.0%
Sema.NumFunctionsTypechecked 1,526 1,526 0 0.0%
Sema.NumGenericSignatureBuilders 1,676 1,676 0 0.0%
Sema.NumLazyGenericEnvironments 6,204 6,204 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 130 130 0 0.0%
Sema.NumLazyIterableDeclContexts 4,259 4,259 0 0.0%
Sema.NumTypesDeserialized 17,077 17,077 0 0.0%
Sema.NumTypesValidated 6,954 6,954 0 0.0%

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please smoke test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2019

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

Regressions found (see below)

Debug

debug brief

Regressed (1)
name old new delta delta_pct
time.swift-driver.wall 8.4s 8.6s 195.7ms 2.32% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 99,933,677,640 99,899,236,853 -34,440,787 -0.03%
LLVM.NumLLVMBytesOutput 6,167,140 6,167,224 84 0.0%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumLoadedModules 660 660 0 0.0%
AST.NumTotalClangImportedEntities 3,832 3,832 0 0.0%
IRModule.NumIRBasicBlocks 18,746 18,746 0 0.0%
IRModule.NumIRFunctions 10,616 10,616 0 0.0%
IRModule.NumIRGlobals 8,111 8,111 0 0.0%
IRModule.NumIRInsts 313,612 313,612 0 0.0%
IRModule.NumIRValueSymbols 17,790 17,790 0 0.0%
LLVM.NumLLVMBytesOutput 6,167,140 6,167,224 84 0.0%
SILModule.NumSILGenFunctions 5,372 5,372 0 0.0%
SILModule.NumSILOptFunctions 7,006 7,006 0 0.0%
Sema.NumConformancesDeserialized 13,773 13,773 0 0.0%
Sema.NumConstraintScopes 38,396 38,408 12 0.03%
Sema.NumDeclsDeserialized 115,216 115,216 0 0.0%
Sema.NumDeclsValidated 10,762 10,762 0 0.0%
Sema.NumFunctionsTypechecked 1,516 1,516 0 0.0%
Sema.NumGenericSignatureBuilders 4,249 4,249 0 0.0%
Sema.NumLazyGenericEnvironments 23,281 23,281 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 1,942 1,942 0 0.0%
Sema.NumLazyIterableDeclContexts 18,565 18,565 0 0.0%
Sema.NumTypesDeserialized 44,874 44,874 0 0.0%
Sema.NumTypesValidated 11,624 11,624 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 141,707,555,079 141,622,683,753 -84,871,326 -0.06%
LLVM.NumLLVMBytesOutput 7,189,264 7,189,196 -68 -0.0%
time.swift-driver.wall 16.2s 16.2s 2.7ms 0.02%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumLoadedModules 76 76 0 0.0%
AST.NumTotalClangImportedEntities 2,226 2,226 0 0.0%
IRModule.NumIRBasicBlocks 21,135 21,135 0 0.0%
IRModule.NumIRFunctions 10,104 10,104 0 0.0%
IRModule.NumIRGlobals 8,129 8,129 0 0.0%
IRModule.NumIRInsts 224,424 224,424 0 0.0%
IRModule.NumIRValueSymbols 17,407 17,407 0 0.0%
LLVM.NumLLVMBytesOutput 7,189,264 7,189,196 -68 -0.0%
SILModule.NumSILGenFunctions 4,178 4,178 0 0.0%
SILModule.NumSILOptFunctions 5,847 5,847 0 0.0%
Sema.NumConformancesDeserialized 12,323 12,323 0 0.0%
Sema.NumConstraintScopes 38,226 38,238 12 0.03%
Sema.NumDeclsDeserialized 31,871 31,871 0 0.0%
Sema.NumDeclsValidated 7,784 7,784 0 0.0%
Sema.NumFunctionsTypechecked 1,526 1,526 0 0.0%
Sema.NumGenericSignatureBuilders 1,676 1,676 0 0.0%
Sema.NumLazyGenericEnvironments 6,204 6,204 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 130 130 0 0.0%
Sema.NumLazyIterableDeclContexts 4,259 4,259 0 0.0%
Sema.NumTypesDeserialized 17,077 17,077 0 0.0%
Sema.NumTypesValidated 6,954 6,954 0 0.0%

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

I think these 195 ms if difference in debug build are just noise because no other counters have changed.

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please test source compatibility

@xedin xedin force-pushed the diagnose-mutable-methods branch from 23d9722 to 2404826 Compare July 9, 2019 07:25
@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please test source compatibility

@swiftlang swiftlang deleted a comment from swift-ci Jul 9, 2019
@swiftlang swiftlang deleted a comment from swift-ci Jul 9, 2019
hamishknight
hamishknight reviewed Jul 9, 2019
View reviewed changes
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please test

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2019

@swift-ci please test

@xedin xedin merged commit 81a69f3 into swiftlang:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishknight hamishknight hamishknight left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @swift-ci @hamishknight