[CMake] Make swift-frontend the primary Swift binary. #28003

DougGregor · 2019-10-31T22:46:54Z

Build swift-frontend as the primary Swift binary, and have
swift/swiftc/etc. symlink over to it. This is a step toward allowing
swift-driver to replace swift and swiftc binaries.

DougGregor · 2019-10-31T22:47:02Z

@swift-ci please test

DougGregor · 2019-10-31T22:47:12Z

@swift-ci please test platform windows

swift-ci · 2019-10-31T23:14:26Z

Build failed
Swift Test OS X Platform
Git Sha - 034daa821c3b3843aecb51d0f4963a09ecba3b6c

swift-ci · 2019-10-31T23:35:30Z

Build failed
Swift Test Linux Platform
Git Sha - 034daa821c3b3843aecb51d0f4963a09ecba3b6c

DougGregor · 2019-11-01T16:59:01Z

@swift-ci please test

DougGregor · 2019-11-01T16:59:11Z

@swift-ci please test platform Windows

swift-ci · 2019-11-01T17:01:30Z

Build failed
Swift Test Linux Platform
Git Sha - 034daa821c3b3843aecb51d0f4963a09ecba3b6c

swift-ci · 2019-11-01T17:03:20Z

Build failed
Swift Test OS X Platform
Git Sha - 034daa821c3b3843aecb51d0f4963a09ecba3b6c

compnerd · 2019-11-06T15:48:16Z

@swift-ci please test Windows platform

DougGregor · 2019-11-07T05:17:42Z

@swift-ci please test Windows platform

How can I track down the results when we run these tests?

drodriguez · 2019-11-07T05:51:15Z

https://ci-external.swift.org/view/Pull%20Request/job/swift-PR-windows/160/ (but I don't know why it wasn't reported back here).

DougGregor · 2020-06-15T18:32:31Z

@swift-ci please test

swift-ci · 2020-06-15T20:15:43Z

Build failed
Swift Test Linux Platform
Git Sha - 28d1b23f6783b4c53184611e2e9beb15bd24137e

DougGregor · 2020-06-16T23:53:40Z

@swift-ci test

DougGregor · 2020-06-16T23:53:51Z

@swift-ci test source compatibility

swift-ci · 2020-06-17T01:19:38Z

Build failed
Swift Test Linux Platform
Git Sha - cc23d4d52b2cb96a8c684f0ab5e619b63a8282f4

swift-ci · 2020-06-17T02:17:55Z

Build failed
Swift Test OS X Platform
Git Sha - cc23d4d52b2cb96a8c684f0ab5e619b63a8282f4

DougGregor · 2020-06-19T20:59:37Z

@swift-ci please test

swift-ci · 2020-06-19T21:00:02Z

Build failed
Swift Test Linux Platform
Git Sha - cc23d4d52b2cb96a8c684f0ab5e619b63a8282f4

swift-ci · 2020-06-19T21:02:14Z

Build failed
Swift Test OS X Platform
Git Sha - cc23d4d52b2cb96a8c684f0ab5e619b63a8282f4

DougGregor · 2020-06-19T22:01:25Z

@swift-ci please test

DougGregor · 2020-06-19T22:01:36Z

@swift-ci please test

swift-ci · 2020-06-19T22:32:06Z

Build failed
Swift Test OS X Platform
Git Sha - 7e13bf704f3fb7292f8cf2280633cf8230da0cea

DougGregor · 2020-06-19T23:14:17Z

@swift-ci please test

DougGregor · 2020-06-19T23:40:05Z

@swift-ci test macOS

swift-ci · 2020-06-19T23:51:45Z

Build failed
Swift Test Linux Platform
Git Sha - 7e13bf704f3fb7292f8cf2280633cf8230da0cea

swift-ci · 2020-06-20T01:02:36Z

Build failed
Swift Test Linux Platform
Git Sha - 9fbf83a4f48b8dc4bd7913c3d1188cc370724a50

swift-ci · 2020-06-20T01:02:41Z

Build failed
Swift Test OS X Platform
Git Sha - 9fbf83a4f48b8dc4bd7913c3d1188cc370724a50

DougGregor · 2020-06-20T04:13:53Z

@swift-ci please test source compatibility

DougGregor · 2020-06-20T04:14:00Z

@swift-ci please smoke test

DougGregor · 2020-06-20T04:24:01Z

@swift-ci please smoke test

Build swift-frontend as the primary Swift binary, and have swift/swiftc/etc. symlink over to it. This is a step toward allowing swift-driver to replace the swift and swiftc binaries.

This obviates the need for "-frontend", although we still accept it for backward compatibility. Switch lit's %target-swift-frontend et al over to calling swift-frontend.

Hardlinking to a symlink is not permitted, so use "swift-frontend" instead of "swift" as the hard-link target. Also, update one Linux-specific test to check for swift-frontend.

swift-ci · 2020-06-23T22:14:29Z

Build failed
Swift Test Linux Platform
Git Sha - 9fbf83a4f48b8dc4bd7913c3d1188cc370724a50

swift-ci · 2020-06-23T22:14:35Z

Build failed
Swift Test OS X Platform
Git Sha - 9fbf83a4f48b8dc4bd7913c3d1188cc370724a50

DougGregor · 2020-06-23T22:16:47Z

@swift-ci please test source compatibility Debug

DougGregor · 2020-06-23T22:17:44Z

@swift-ci please test source compatibility Debug

DougGregor · 2020-06-23T22:20:45Z

@swift-ci please test source compatibility Debug

DougGregor · 2020-06-23T22:37:58Z

@swift-ci please test source compatibility debug

DougGregor · 2020-06-24T04:39:11Z

Source-compatibility failures are actually UPASS's, so we'll get that cleaned up. Windows failure is unrelated. Time to merge!

davezarzycki · 2020-06-24T09:46:07Z

Hi @DougGregor – This broke unified builds:

CMake Error at /home/dave/s/u/swift/tools/swift-remoteast-test/CMakeLists.txt:13 (add_dependencies):
  Cannot add target-level dependencies to non-existent target "swift".

  The add_dependencies works for top-level logical targets created by the
  add_executable, add_library, or add_custom_target commands.  If you want to
  add file-level dependencies see the DEPENDS option of the add_custom_target
  and add_custom_command commands.

[CMake] Fix unified builds after #28003

DougGregor force-pushed the swift-frontend-rename branch from 034daa8 to 409509f Compare November 1, 2019 16:58

DougGregor mentioned this pull request Jan 2, 2020

Handle -version argument swiftlang/swift-driver#49

Merged

cltnschlosser mentioned this pull request Jun 1, 2020

Update README to avoid recursive lookups swiftlang/swift-driver#114

Merged

DougGregor force-pushed the swift-frontend-rename branch 2 times, most recently from 82ba0c4 to 28d1b23 Compare June 15, 2020 18:32

DougGregor force-pushed the swift-frontend-rename branch from 28d1b23 to cc23d4d Compare June 16, 2020 23:53

DougGregor added 9 commits June 23, 2020 13:00

[CMake] Make swift-frontend the primary Swift binary.

f71f620

Build swift-frontend as the primary Swift binary, and have swift/swiftc/etc. symlink over to it. This is a step toward allowing swift-driver to replace the swift and swiftc binaries.

Fix build of benchmark suite and Linux test

ade21a3

[Driver] Execute the frontend when invoked via swift-frontend.

6c0d957

This obviates the need for "-frontend", although we still accept it for backward compatibility. Switch lit's %target-swift-frontend et al over to calling swift-frontend.

[Test] Fix a test for Windows

bd95fcb

Install swift-frontend executable

bb2d6c5

Linux-specific fixes for the swift-frontend rename.

480c631

Hardlinking to a symlink is not permitted, so use "swift-frontend" instead of "swift" as the hard-link target. Also, update one Linux-specific test to check for swift-frontend.

[Frontend rename] Fix another Linux test

49dfa8f

Disable test on Windows where we don't have symlinks

9c4a189

[Build] Don't install swift-frontend twice, incorrectly

d49e4a2

DougGregor force-pushed the swift-frontend-rename branch from 9fbf83a to d49e4a2 Compare June 23, 2020 21:14

DougGregor merged commit 1725ece into swiftlang:master Jun 24, 2020

DougGregor deleted the swift-frontend-rename branch June 24, 2020 04:40

davezarzycki added a commit to davezarzycki/swift that referenced this pull request Jun 24, 2020

[CMake] Fix unified builds after swiftlang#28003

55517d2

davezarzycki added a commit that referenced this pull request Jun 24, 2020

Merge pull request #32522 from davezarzycki/pr32522

00d5839

[CMake] Fix unified builds after #28003

compnerd mentioned this pull request Sep 4, 2020

Update CMakeLists.txt swiftlang/llvm-project#1757

Merged

[CMake] Make swift-frontend the primary Swift binary. #28003

[CMake] Make swift-frontend the primary Swift binary. #28003

Uh oh!

Conversation

DougGregor commented Oct 31, 2019

Uh oh!

DougGregor commented Oct 31, 2019

Uh oh!

DougGregor commented Oct 31, 2019

Uh oh!

swift-ci commented Oct 31, 2019

Uh oh!

swift-ci commented Oct 31, 2019

Uh oh!

DougGregor commented Nov 1, 2019

Uh oh!

DougGregor commented Nov 1, 2019

Uh oh!

swift-ci commented Nov 1, 2019

Uh oh!

swift-ci commented Nov 1, 2019

Uh oh!

compnerd commented Nov 6, 2019

Uh oh!

DougGregor commented Nov 7, 2019

Uh oh!

drodriguez commented Nov 7, 2019

Uh oh!

DougGregor commented Jun 15, 2020

Uh oh!

swift-ci commented Jun 15, 2020

Uh oh!

DougGregor commented Jun 16, 2020

Uh oh!

DougGregor commented Jun 16, 2020

Uh oh!

swift-ci commented Jun 17, 2020

Uh oh!

swift-ci commented Jun 17, 2020

Uh oh!

DougGregor commented Jun 19, 2020

Uh oh!

swift-ci commented Jun 19, 2020

Uh oh!

swift-ci commented Jun 19, 2020

Uh oh!

DougGregor commented Jun 19, 2020

Uh oh!

DougGregor commented Jun 19, 2020

Uh oh!

swift-ci commented Jun 19, 2020

Uh oh!

DougGregor commented Jun 19, 2020

Uh oh!

DougGregor commented Jun 19, 2020

Uh oh!

swift-ci commented Jun 19, 2020

Uh oh!

swift-ci commented Jun 20, 2020

Uh oh!

swift-ci commented Jun 20, 2020

Uh oh!

DougGregor commented Jun 20, 2020

Uh oh!

DougGregor commented Jun 20, 2020

Uh oh!

DougGregor commented Jun 20, 2020

Uh oh!

swift-ci commented Jun 23, 2020

Uh oh!

swift-ci commented Jun 23, 2020

Uh oh!

DougGregor commented Jun 23, 2020

Uh oh!

DougGregor commented Jun 23, 2020

Uh oh!

DougGregor commented Jun 23, 2020

Uh oh!

DougGregor commented Jun 23, 2020

Uh oh!