[AutoDiff] Fix activity analysis use-after-free crash. #28285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `DifferentiableActivityInfo::getLookupConformanceFunction`, which returned a `LookupConformanceFn` (type alias for `LookupConformanceFn`), which does not own the underlying callable. Add a `DifferentiableActivityInfo::hasTangentSpace` helper, which is easier to use and avoids the issue. Resolves TF-945.
|
@swift-ci Please test tensorflow |
marcrasi
approved these changes
Nov 15, 2019
rxwei
approved these changes
Nov 15, 2019
bgogul
pushed a commit
that referenced
this pull request
Nov 19, 2019
Remove `DifferentiableActivityInfo::getLookupConformanceFunction`, which returned a `LookupConformanceFn` (type alias for `LookupConformanceFn`), which does not own the underlying callable. Add a `DifferentiableActivityInfo::hasTangentSpace` helper, which is easier to use and avoids the issue. Resolves TF-945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
DifferentiableActivityInfo::getLookupConformanceFunction, whichreturned a
LookupConformanceFn(type alias forLookupConformanceFn),which does not own the underlying callable.
Add a
DifferentiableActivityInfo::hasTangentSpacehelper, which is easierto use and avoids the issue.
Resolves TF-945.