Skip to content

Removes redundant buffer zeroing in Metal.swift by using init(unsafeUninitializedCapacity:initializingWith:) #30133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Removes redundant buffer zeroing in Metal.swift by using init(unsafeUninitializedCapacity:initializingWith:) #30133

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8142d0f
Removes redandant buffer zeroing
valeriyvan Feb 28, 2020
cf95a2f
Fixes typo
valeriyvan Feb 28, 2020
e755dec
Fix compile error
valeriyvan Mar 13, 2020
0909a7a
Merge branch 'master' into RemoveRedundantZeroingMetal
valeriyvan Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions stdlib/public/Darwin/Metal/Metal.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,10 @@ extension MTLDevice {

@available(macOS 10.13, iOS 11.0, tvOS 11.0, *)
public func getDefaultSamplePositions(sampleCount: Int) -> [MTLSamplePosition] {
var positions = [MTLSamplePosition](repeating: MTLSamplePosition(x: 0,y: 0), count: sampleCount)
__getDefaultSamplePositions(&positions, count: sampleCount)
return positions
return [MTLSamplePosition](unsafeUninitializedCapacity: sampleCount) { buf, initializedCount in
__getDefaultSamplePositions(buf.baseAddress!, count: sampleCount)
initializedCount = sampleCount
}
}
}

Expand Down Expand Up @@ -263,9 +264,10 @@ extension MTLRenderPassDescriptor {
@available(macOS 10.13, iOS 11.0, tvOS 11.0, *)
public func getSamplePositions() -> [MTLSamplePosition] {
let numPositions = __getSamplePositions(nil, count: 0)
var positions = [MTLSamplePosition](repeating: MTLSamplePosition(x: 0,y: 0), count: numPositions)
__getSamplePositions(&positions, count: numPositions)
return positions
return [MTLSamplePosition](unsafeUninitializedCapacity: numPositions) { buf, initializedCount in
__getSamplePositions(buf.baseAddress!, count: numPositions)
initializedCount = numPositions
}
}

}
Expand Down