swift-reflection-dump support for unresolved opaque return types.
#31026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve mangled names containing symbolic references to indirect opaque type descriptors from other dylibs by demangling the referenced symbol name, like we do for other kinds of context descriptor. Add an OpaqueArchetypeTypeRef that can represent unresolved opaque types in the Reflection library.
|
@swift-ci Please test |
xedin
reviewed
Apr 16, 2020
| @@ -372,6 +372,7 @@ class TypeRefBuilder { | |||
| unsigned ordinal) { | |||
| // TODO: Produce a type ref for the opaque type if the underlying type isn't | |||
| // available. | |||
| opaqueDescriptor->dump(); | |||
There was a problem hiding this comment.
@jckarter Is this intentional? Looks like it causes linker failures in some configurations.
There was a problem hiding this comment.
Oops, no, it can be removed. I'll take care of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve mangled names containing symbolic references to indirect opaque type descriptors from other
dylibs by demangling the referenced symbol name, like we do for other kinds of context descriptor.
Add an OpaqueArchetypeTypeRef that can represent unresolved opaque types in the Reflection library.