[OSLog Diagnostics] Improve os log diagnostics emitted in the SIL and Sema diagnostic passes. #31129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suppressGlobalStringTablePointerError of OSLogOptimization pass that happens because of eagerly deleting instructions while iterating on them. This was fixed using the InstructionDeleter utility.
|
@swift-ci Please test |
…iagnostic passes for the os log APIs. These improvements are aimed at covering some rare corner cases.
ravikandhadai
force-pushed
the
oslog-diagnostic-improvement
branch
from
f91e526 to
2e0457a
Compare
|
@swift-ci Please clean test |
|
Build failed |
|
Build failed |
|
@swift-ci Please smoke test Linux Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These improvements are aimed at covering some rare corner cases. Only the commit f91e526 has the relevant changes. The previous commit belongs to a previous PR