Skip to content

ReplaceOpaqueTypesWithUnderlyingTypes: Handle a type being "substituted" with itself. #31773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jckarter
Copy link
Contributor

SIL type lowering might have already substituted away an opaque type during a SIL substitution.
Fixes rdar://problem/62072397.

@jckarter jckarter requested a review from aschwaighofer May 13, 2020 23:42
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5061e50681b861efa6895cc4fd091e57665860cf

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5061e50681b861efa6895cc4fd091e57665860cf

…ed" with itself.

SIL type lowering might have already substituted away an opaque type during a SIL substitution.
Fixes rdar://problem/62072397.
@jckarter jckarter force-pushed the replace-opaque-underlying-type-with-underlying-type branch from 5061e50 to 94849de Compare May 14, 2020 17:22
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5061e50681b861efa6895cc4fd091e57665860cf

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5061e50681b861efa6895cc4fd091e57665860cf

@jckarter
Copy link
Contributor Author

@swift-ci Please test OS X

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants