Skip to content

Demangling variadic tuples should not crash #31988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 12, 2020
Merged

Demangling variadic tuples should not crash #31988

merged 10 commits into from
Jun 12, 2020

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented May 23, 2020

Although variadic tuples per se are no longer supported, there is still code in the demangler to recognize these types. This one-line change fixes a typo in that code that was introduced in e427ded.

Resolves rdar://63342277

@tbkka tbkka requested a review from eeckstein May 23, 2020 01:27
@tbkka
Copy link
Contributor Author

tbkka commented May 23, 2020

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

Should we just remove this code? Variadic tuples were never a supported feature.

@slavapestov
Copy link
Contributor

Also can you add a test case to test/Demangler?

tbkka
tbkka commented May 26, 2020
View reviewed changes
@tbkka
Copy link
Contributor Author

tbkka commented Jun 4, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test Linux Platform
Git Sha - b3ffeb5

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - b3ffeb5

tbkka
tbkka commented Jun 5, 2020
View reviewed changes
@tbkka
Copy link
Contributor Author

tbkka commented Jun 5, 2020

@swift-ci Please test

1 similar comment
@tbkka
Copy link
Contributor Author

tbkka commented Jun 6, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 6, 2020

Build failed
Swift Test OS X Platform
Git Sha - 21c70d5

@swift-ci
Copy link
Contributor

swift-ci commented Jun 6, 2020

Build failed
Swift Test Linux Platform
Git Sha - 21c70d5

eeckstein
eeckstein approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tbkka
This test verifies the behavior of the demangler, not the type decoder.
9d125ea 
So valid demanglings of invalid types are actually accepted here.
@tbkka
Copy link
Contributor Author

tbkka commented Jun 8, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 8, 2020

Build failed
Swift Test Linux Platform
Git Sha - 95fff9c

@swift-ci
Copy link
Contributor

swift-ci commented Jun 8, 2020

Build failed
Swift Test OS X Platform
Git Sha - 95fff9c

@tbkka
Copy link
Contributor Author

tbkka commented Jun 9, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 9d125ea

@tbkka
Copy link
Contributor Author

tbkka commented Jun 9, 2020

@swift-ci Please test

@tbkka
Copy link
Contributor Author

tbkka commented Jun 9, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 9d125ea

@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2020

Build failed
Swift Test OS X Platform
Git Sha - 9d125ea

@tbkka
Copy link
Contributor Author

tbkka commented Jun 9, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 0927930

@tbkka
Copy link
Contributor Author

tbkka commented Jun 10, 2020

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0927930

@tbkka
Copy link
Contributor Author

tbkka commented Jun 11, 2020

@swift-ci Please test Linux Platform

@tbkka tbkka merged commit 0855829 into swiftlang:master Jun 12, 2020
@tbkka tbkka deleted the tbkka-rdar63342277-variadic-tuple-mangling branch October 16, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbkka @slavapestov @swift-ci @eeckstein