[SR-12869] [Diagnostics] Fixes assertion hit on TupleContextualFailure involving optional tuple type #32001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual if we already record a tuple mismatch
…e Subscript assign to source
LucianoPAlmeida
changed the title
xedin
requested changes
May 25, 2020
There was a problem hiding this comment.
Let's adjust logic related to CTP_SubscriptAssignSource and we'll be good to go. Thank you, @LucianoPAlmeida!
…r assign expr in getStructuralTypeContext
xedin
approved these changes
May 26, 2020
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
2 similar comments
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crasher on the
TupleContextualFailurewhen involving optional tuple type.It also resolves a duplicated diagnostic when it diagnoses the mismatch in
IgnoreAssignmentDestinationType/ContextualMismatchandAllowTupleMismatch.cc @xedin :)
Resolves SR-12869.