[CMake] Simplify two binary variables into one tri-state variable #32042
Conversation
|
@swift-ci please test |
| # FIXME: On Apple platforms, find_program needs to look for "ld64.lld" | ||
| find_program(LDLLD_PATH "ld.lld") | ||
| if((SWIFT_ENABLE_LLD_LINKER AND LDLLD_PATH AND NOT APPLE) OR | ||
| if((SWIFT_USE_LINKER STREQUAL "lld") OR |
There was a problem hiding this comment.
I think that we should simplify this like the previous case in cmake/modules/AddSwift.cmake
| ("${LFLAGS_SDK}" STREQUAL "WINDOWS" AND | ||
| NOT "${CMAKE_SYSTEM_NAME}" STREQUAL "WINDOWS")) | ||
| list(APPEND result "-fuse-ld=lld") | ||
| elseif(SWIFT_ENABLE_GOLD_LINKER AND | ||
| elseif(SWIFT_USE_LINKER STREQUAL "gold" AND |
There was a problem hiding this comment.
I think the manipulations around these lines (L418-L422) are the same to the ones in AddSwiftUnittests.cmake, but the modifications are different: some checks are kept here, while they are drop in the other file. Is the divergence intentional?
|
Build failed |
Also remove some ancient logic to detect and ignore requests to use LLD. If people want to explicitly use LLD, they probably have a reason and we shouldn't second guess them.
|
Hi @compnerd and @drodriguez – I've simplified AddSwiftStdlib.cmake more. I think we should make @swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please clean test linux |
|
Yeah, I agree on the idea that if the user specified it, we assume correct and honor it. |
|
@swift-ci please test windows |
Also remove some ancient logic to detect and ignore requests to use LLD. If people want to explicitly use LLD, they probably have a reason and we shouldn't second guess them.