Skip to content

[AutoDiff upstream] Add forward-mode differentiation runtime tests. #32106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2020

Conversation

dan-zheng
Copy link
Contributor

@dan-zheng dan-zheng commented May 30, 2020

Forward-mode differentiation development isn't currently prioritized, but
upstreaming tests allows us to prevent regressions.

Expose SR-12911: forward-mode differentiation runtime segfault.


Upstreaming test/AutoDiff/validation-test/forward_mode.swift now
because I want to add to it in an upcoming PR.

@dan-zheng dan-zheng requested a review from rxwei May 30, 2020 19:54
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1927a05834f8daa725a43d3cda6258690d73c8d5

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1927a05834f8daa725a43d3cda6258690d73c8d5

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1927a05834f8daa725a43d3cda6258690d73c8d5

Forward-mode differentiation development isn't currently prioritized, but
upstreaming tests allows us to prevent regressions.

Expose SR-12911: forward-mode differentiation runtime segfault.
@dan-zheng
Copy link
Contributor Author

I removed the negative test for SR-12911 because it's platform-dependent and fragile.

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a2169400ca1db30f14890af47dab25ee4c2ae4f1

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a2169400ca1db30f14890af47dab25ee4c2ae4f1

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test Linux

@rxwei
Copy link
Contributor

rxwei commented May 31, 2020

Lgtm

@dan-zheng dan-zheng merged commit 756788e into swiftlang:master May 31, 2020
@dan-zheng dan-zheng deleted the autodiff-testing branch May 31, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants