ExplicitModuleLoader: take a JSON file that specifies details of explicit Swift modules #32355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcsgexi
force-pushed
the
json-for-explicit-swift-modules
branch
2 times, most recently
from
0d24dad to
38e7360
Compare
…icit Swift modules Instead of taking paths of Swift module files from front-end command line arguments, we should take a JSON file specifying details of explicit modules. The advantages is (1) .swiftdoc and .swiftsourceinfo can be associated with a .swiftmodule file, and (2) module names are explicitly used as keys in the JSON input so we don't need to eagerly deserialize a .swiftmodule file to collect the module name.
nkcsgexi
force-pushed
the
json-for-explicit-swift-modules
branch
from
38e7360 to
1cb4eda
Compare
nkcsgexi
changed the title
|
@swift-ci please test |
|
Build failed |
|
@swift-ci Please smoke test Linux platform |
|
@nkcsgexi - this seems to have caused a regression on the windows CI: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/1770/consoleText Could you please take a look? |
|
@compnerd ah, Will do. Thanks for pinging! |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jun 18, 2020
Fix the tests that swiftlang#32355 broke.
stephentyrone
pushed a commit
that referenced
this pull request
Jun 19, 2020
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file`
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 22, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 22, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 22, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 23, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 23, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 23, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 24, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 29, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jul 1, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jul 1, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
xymus
pushed a commit
to xymus/swift-driver
that referenced
this pull request
Nov 6, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking paths of Swift module files from front-end command line
arguments, we should take a JSON file specifying details of explicit modules.
The advantages is (1) .swiftdoc and .swiftsourceinfo can be associated
with a .swiftmodule file, and (2) module names are explicitly used as
keys in the JSON input so we don't need to eagerly deserialize a .swiftmodule
file to collect the module name.