Skip to content

[ConstraintSystem] Stop type checking TapExpr elements in shrink() #32438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 17, 2020

TapExpr has a VarDecl the type of which is determined by type checking the parent interpolated string literal expression. Type checking TapExpr elements before that always fails, thus a waste of the computing time.

TapExpr has a 'VarDecl' the type of which is determined by type checking
the parent interpolated string literal expression. Type checking TapExpr
elements before that always fails, thus a waste of the computing time.
@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

@swift-ci Please smoke test

@rintaro rintaro requested a review from xedin June 17, 2020 17:37
@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

https://ci.swift.org/job/swift-PR-osx-smoke-test/23199/console

/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/Parse/pointer_conversion.swift.gyb:310:43: error: incorrect message found
  let a: Bool = x == y // expected-error{{referencing operator function '==' on 'Array' requires that 'NotEquatable' conform to 'Equatable'}}
                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                          operator function '==' requires that 'NotEquatable' conform to 'Equatable'

Not sure this is caused by the patch.

@xedin
Copy link
Contributor

xedin commented Jun 17, 2020

@rintaro I don't think it is, I'm still trying to track down why this happens...

@xedin
Copy link
Contributor

xedin commented Jun 17, 2020

@swift-ci please smoke test macOS platform

@rintaro rintaro merged commit 2edae95 into swiftlang:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants