Skip to content

[5.3][CodeCompletion] Suggest 'macOS' instead of 'OSX' #32441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

[5.3][CodeCompletion] Suggest 'macOS' instead of 'OSX' #32441

merged 1 commit into from
Jun 17, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 17, 2020 •
edited
Loading

Cherry-pick of #32440 into release/5.3

  • Explanation: for @available attribute and #available statement condition, macOS is preferred over OSX. Since OSX is deprecated, suggest macOS instead of OSX.
  • Scope: Code completion inside @available and #available
  • Risk: Very low. The change is simple and scope is limited
  • Testing: Passed updated regression test cases
  • Issue: rdar://problem/64379019
  • Reviewer: Argyrios Kyrtzidis (@akyrtzi)

@rintaro rintaro added the r5.3 label Jun 17, 2020
@rintaro rintaro requested a review from a team as a code owner June 17, 2020 20:38
@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

@swift-ci Please test

@rintaro
[CodeCompeltion] Suggest 'macOS' instead of 'OSX'
a0c914c 
'macOS' is the preferred name for specifying the platform. Since 'OSX'
is deprecated, we don't need to suggest 'OSX' variants.

rdar://problem/64379019
(cherry picked from commit d4da603)
@rintaro rintaro force-pushed the 5.3-ide-completion-platform-rdar64379019 branch from 98298f5 to a0c914c Compare June 17, 2020 21:12
@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

@swift-ci Please test

@swift-ci

This comment has been minimized.

Sign in to view
@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

Windows: https://ci-external.swift.org/job/swift-PR-windows/4291/

@swift-ci

This comment has been minimized.

Sign in to view
@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

@swift-ci Please nominate

@tkremenek tkremenek merged commit c93c434 into swiftlang:release/5.3 Jun 17, 2020
@rintaro rintaro deleted the 5.3-ide-completion-platform-rdar64379019 branch June 18, 2020 00:46
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkremenek tkremenek tkremenek approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rintaro @swift-ci @tkremenek @AnthonyLatsis