[Runtime] Add entry point to canonicalize metadata. #32506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
nate-chandler
force-pushed
the
runtime/add-swift_getCanonicalSpecializedMetadata
branch
from
0b7141d to
bb9a7f2
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test windows platform |
jckarter
reviewed
Jun 30, 2020
The new function swift_getCanonicalSpecializedMetadata takes a metadata request, a prespecialized non-canonical metadata, and a cache as its arguments. The idea of the function is either to bless the provided prespecialized metadata as canonical if there is not currently a canonical metadata record for the type it describes or else to return the actual canonical metadata. When called, the metadata cache checks for a preexisting entry for this metadata. If none is found, the passed-in prespecialized metadata is added to the cache. Otherwise, the metadata record found in the cache is returned. rdar://problem/56995359
nate-chandler
force-pushed
the
runtime/add-swift_getCanonicalSpecializedMetadata
branch
from
bb9a7f2 to
b0fc8da
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test linux |
nate-chandler
deleted the
runtime/add-swift_getCanonicalSpecializedMetadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new function
swift_getCanonicalSpecializedMetadatatakes a metadata request, a prespecialized non-canonical metadata, and a cache as its arguments. The idea of the function is either to bless the provided prespecialized metadata as canonical if there is not currently a canonical metadata record for the type it describes or else to return the actual canonical metadata.When called, the metadata cache checks for a preexisting entry for this metadata. If none is found, the passed-in prespecialized metadata is added to the cache. Otherwise, the metadata record found in the cache is returned.
Until the ability to look through a type's canonical prespecializations is added,
swift_getCanonicalSpecializedMetadatacan't look through the canonical prespecializations that have been created for the generic nominal type in order to return it. Consequently, it must only be called with arguments which can be statically known not to have been possible to canonically prespecialize--for example, it would be sufficient to know that one of the generic arguments is from the module in which the non-canonical prespecialization is defined.rdar://problem/56995359