[5.3][CodeCompletion] Assume non-'isSimpleDidSet' in code completion #32532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Code completion always want to see implicit 'oldValue' with the correct type. Return 'false' from 'SimpleDidSetRequest' in code completion mode. rdar://problem/64699286 (cherry picked from commit 21b9fc3)
rintaro
force-pushed
the
5.3-ide-completion-rdar64699286
branch
from
752fe6c to
064749e
Compare
|
@swift-ci Please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci Please nominate |
tkremenek
approved these changes
Jun 25, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #32528 into
release/5.3oldValueindidSetblocks. This patch fixes the regression by retuningfalsefromSimpleDidSetRequestin code completion mode so that theoldValueis correctly populated.didSetblock