Skip to content

[docs] Add documentation describing external resources. #32584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

varungandhi-apple
Copy link
Contributor

First follow-up to #32008.

cc @HassanElDesouky

@varungandhi-apple varungandhi-apple requested review from xwu and owenv June 27, 2020 05:23
Copy link
Contributor

@HassanElDesouky HassanElDesouky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really looks good! I've left a minor comment regarding spelling. But overall this is a great job! :)

Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it's great to see all this info collected in one place!

@varungandhi-apple varungandhi-apple force-pushed the vg-docs-add-external-resources branch from 26bb9da to dc6db19 Compare June 29, 2020 16:32
@varungandhi-apple
Copy link
Contributor Author

Addressed review comments.

@swift-ci please smoke test

@varungandhi-apple varungandhi-apple merged commit 440cd0b into swiftlang:master Jun 29, 2020
@varungandhi-apple varungandhi-apple deleted the vg-docs-add-external-resources branch June 29, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants