[5.3] Handle Boolean Patterns Matching Against Invalid Constructor Forms #32823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
changed the title
nathawes
approved these changes
Jul 10, 2020
|
@swift-ci test |
The Space Engine maintains as one of its invariants that the AST it is handed must at least typecheck. When swift typechecks patterns, the only case one is allowed to form a Boolean pattern is when a literal is expected, and the corresponding type of the pattern clause is exactly Bool. This precludes the use of other types, including ExpressibleByBooleanLiteral types, from matching. Thus, this code path was never hit. That is, until we accidentally lifted the restriction on enum case base name overloading too early. Now, it is possible for the space engine to see the same constructor head that has subspaces with different argument types. The space engine is relatively tolerant of this bizarre situation, but in this one narrow case it was not. This patch has a narrow fix to add the missing case to the space engine. In the long term, we need to actually finish SE-0155 which will make this crash structurally impossible once again. Resolves rdar://65229620
CodaFi
force-pushed
the
enhanced-spacial-reasoning
branch
from
12e9dfb to
02dca7e
Compare
|
@swift-ci test |
DougGregor
approved these changes
Jul 11, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32822