Skip to content

[5.3] Mark main() as used #33177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

[5.3] Mark main() as used #33177

merged 1 commit into from
Jul 31, 2020

Conversation

beccadax
Copy link
Contributor

…except when the integrated REPL is in use. This prevents dead code stripping from removing the main() function used in widgets.

Fixes rdar://65862827.

@beccadax beccadax requested a review from a team as a code owner July 29, 2020 03:23
@beccadax
Copy link
Contributor Author

@swift-ci please test

@jakepetroules
Copy link
Contributor

Thanks!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b1bd9cfb0d2228c5014c44da43b4bf6a007ae9f6

@beccadax beccadax force-pushed the they-buffed-my-main-5.3 branch from b1bd9cf to 09dc59c Compare July 29, 2020 07:20
@beccadax
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b1bd9cfb0d2228c5014c44da43b4bf6a007ae9f6

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b1bd9cfb0d2228c5014c44da43b4bf6a007ae9f6

@beccadax
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 09dc59cb35f6d2719c0ecea06fa181724fd4ca6f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b1bd9cfb0d2228c5014c44da43b4bf6a007ae9f6

@beccadax beccadax changed the title Mark main() as used [5.3] Mark main() as used Jul 29, 2020
@beccadax
Copy link
Contributor Author

Can't reproduce failures locally...

@swift-ci please smoke test macOS platform

@beccadax beccadax force-pushed the they-buffed-my-main-5.3 branch from 09dc59c to 24084a5 Compare July 29, 2020 22:07
@beccadax
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 09dc59cb35f6d2719c0ecea06fa181724fd4ca6f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 09dc59cb35f6d2719c0ecea06fa181724fd4ca6f

@beccadax
Mark main() as used
df260af 
…except when the integrated REPL is in use. This prevents dead code stripping from removing the main() function used in widgets.

Fixes rdar://65862827.
@beccadax beccadax force-pushed the they-buffed-my-main-5.3 branch from 24084a5 to df260af Compare July 30, 2020 00:57
@beccadax
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 24084a5cc287e5f82651e4cc16cbed8816e23641

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 24084a5cc287e5f82651e4cc16cbed8816e23641

@beccadax beccadax requested a review from jckarter July 30, 2020 03:49
@beccadax beccadax mentioned this pull request Jul 30, 2020
Merged
@tkremenek tkremenek merged commit a8dcb57 into swiftlang:release/5.3 Jul 31, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

@tkremenek tkremenek tkremenek approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@beccadax @jakepetroules @swift-ci @jckarter @tkremenek @benrimmington @AnthonyLatsis