[5.3][Diagnostics] Do more checking before recording force downcast fix
#33273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solver should do more checking upfront before recording `force downcast` fix, to make sure that it's indeed always applicable when recorded, otherwise it would be possible to misdiagnose or omit diagnostics in certain situations. Resolves: rdar://problem/65254452 (cherry picked from commit d89c096)
|
@swift-ci please test |
tkremenek
approved these changes
Aug 4, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #33272
Solver should do more checking upfront before recording
force downcastfix, to make sure that it's indeed alwaysapplicable when recorded, otherwise it would be possible
to misdiagnose or omit diagnostics in certain situations.
Scope: Limited to situations when it is possible to find an ObjC bridged type
for right-hand side of the conversion ("to" type) but the other side
("from" type) can't be bridged to such a type.
Resolves: rdar://problem/65254452
Risk: Very Low
Testing: Added regression tests
Reviewer: @hborla
Resolves: rdar://problem/65254452
(cherry picked from commit d89c096)