test: disable a couple of IRGen tests on ASi #33330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS[>=10.14.4] support the ability to update the class metadata, which is used unconditionally with resiliently-sized fields.
|
@swift-ci please test |
slavapestov
approved these changes
Aug 6, 2020
slavapestov
reviewed
Aug 6, 2020
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| // REQUIRES: objc_interop | |||
| // UNSUPPORTED: OS=iosmac | |||
| // UNSUPPORTED: CPU=arm64e | |||
| // UNSUPPORTED: CPU=arm64 || CPU=arm64e | |||
There was a problem hiding this comment.
I thought we had a better way to conditionalize tests on targets that don't have a %target-pre-stable-abi-triple?
There was a problem hiding this comment.
We don't, but, I like your idea, I'll see if I can whip up something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS[>=10.14.4] support the ability to update the class metadata, which
is used unconditionally with resiliently-sized fields.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.