[5.3] Fix crash on circular reference in checkContextualRequirements() #33350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to getGenericSignature() might return nullptr if we encounter a circular reference. Fixes <rdar://problem/64992293>.
|
@swift-ci test |
slavapestov
approved these changes
Aug 7, 2020
CodaFi
force-pushed
the
a-circle-most-vicious
branch
from
e72365d to
d5a7cc4
Compare
|
@swift-ci test |
tkremenek
approved these changes
Aug 7, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #32776
If a circularity issue is diagnosed while resolving a type’s generic signature, the resulting generic signature is null. Clients like type resolution must handle this case explicitly. This patch shores up a case where we did not consider this possibility. It provides a narrow fix for a class of crash-on-invalid bugs that often manifest when users are in the middle of editing code.
Scope: rdar://66287881 shows that users encounter this crash with some regularity while editing code.
Resolves: rdar://problem/66656428, rdar://64992293, rdar://66287881
Risk: Very Low
Testing: Added regression tests
Reviewer: @slavapestov, @CodaFi