SILGen: Fix assertion failure when emitting foreign-to-native thunk for a method with inout 'self' #34456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
foreign-to-native-inout-self
branch
from
d236cb2 to
aa45221
Compare
|
@swift-ci Please smoke test |
jckarter
approved these changes
Oct 27, 2020
…or a method with inout 'self' We import a C function taking a non-const pointer 'self' parameter as a mutating method. The getParameterTypes() helper method in SILGenBridging.cpp would assert upon encountering the inout 'self' parameter, even though emitForeignToNativeThunk() would still emit correct code as long as the 'self' type was not bridged. Relax the assertion a bit to hopefully still catch bugs where other parameters are unexpectedly 'inout', but allow it on 'self', and add a test. Fixes <rdar://problem/70346482>.
slavapestov
force-pushed
the
foreign-to-native-inout-self
branch
from
aa45221 to
51c1fa9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We import a non-const pointer 'self' type as a mutating method.
The getParameterTypes() helper method in SILGenBridging.cpp would
assert upon encountering the inout 'self' parameter, even though
emitForeignToNativeThunk() would still emit correct code as long
as the 'self' type was not bridged.
Relax the assertion a bit to hopefully still catch bugs where
other parameters are unexpectedly 'inout', but allow it on 'self',
and add a test.
Fixes rdar://problem/70346482.