-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[CSBinding] Attempt to join any existing and viable bindings with new… #34834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test source compatibility |
@swift-ci please test |
Looks like there are two failures (Kighfisher, Surge) which both has to do with:
I wonder whether this is related to changes here or something else... |
Ah, looks like this is due to |
… binding Instead of attempting to join only the last recorded supertype binding, let's attempt to join any previously recorded supertype binding with an incoming one to make sure that set contains only the most viable types.
81ac1f4
to
96415b2
Compare
Build failed |
@swift-ci please smoke test |
@swift-ci please smoke test macOS platform |
@swift-ci please smoke test Linux platform |
@swift-ci please smoke test |
@swift-ci please test source compatibility debug |
… binding
Instead of attempting to join only the last recorded supertype
binding, let's attempt to join any previously recorded supertype
binding with an incoming one to make sure that set contains only
the most viable types.