Intrinsics instead of shims #3530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces most of the stubs used for basic operations on these types with intrinsics, eliminating a level of indirection for fma, ceil, floor, round, trunc. square root and remainder still require stubs because there is no remainder intrinsic and we can't use the square root intrinsic because its behavior is undefined for negative inputs. A previous commit apparently either the compiler annotates static inline stubs wrong or the SIL verifier can't handle them, so that change was backed out.
|
@gribozavr @atrick Please take a look. |
|
@swift-ci please test. |
1 task
|
Thanks! I'm merging proactively to get the incremental build fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This replaces most of the stubs used for basic operations on these types with intrinsics, eliminating a level of indirection for fma, ceil, floor, round, trunc.
square root and remainder still require stubs because there is no remainder intrinsic and we can't use the square root intrinsic because its behavior is undefined for negative inputs. A previous commit
apparently either the compiler annotates static inline stubs wrong or the SIL verifier can't handle them, so that change was backed out.
This also fixes the break introduced by reverting #3454.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.