Skip to content

[capture-promotion] Eliminate non-OSSA support/tests. #35790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Feb 5, 2021

This only runs on OSSA now, so I am deleting the non-OSSA tests and put in an
early bail out since there are some tests that have not been updated yet for
OSSA, that run the diagnostic passes, but for which this pass never kicked in
on.

@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 5, 2021

@swift-ci smoke test

This only runs on OSSA now, so I am deleting the non-OSSA tests and put in an
early bail out since there are some tests that have not been updated yet for
OSSA, that run the diagnostic passes, but for which this pass never kicked in
on.

NOTE: I also while updating the tests noticed a bunch were assuming load_borrow
like semantics. So I updated them with that in mind and implemented support in
the pass for that.
@gottesmm gottesmm force-pushed the pr-1fe4c56db40fbe22618e6ca72f441f2e2059152d branch from 2461565 to e33ce42 Compare February 15, 2021 04:49
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm requested review from meg-gupta and atrick February 15, 2021 04:49
@gottesmm gottesmm merged commit 8b563d2 into swiftlang:main Feb 16, 2021
@gottesmm gottesmm deleted the pr-1fe4c56db40fbe22618e6ca72f441f2e2059152d branch February 16, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant