Avoid using strcasecmp and unroll the comparison to 'snan' instead #39182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeash
reviewed
Sep 4, 2021
stdlib/public/stubs/Stubs.cpp
Outdated
| if ((nptr[0] == 's' || nptr[0] == 'S') && | ||
| (nptr[1] == 'n' || nptr[1] == 'N') && | ||
| (nptr[2] == 'a' || nptr[2] == 'A') && | ||
| (nptr[3] == 'n' || nptr[3] == 'N')) { |
There was a problem hiding this comment.
This needs to check index 4 for NUL to be equivalent. Not sure what our actual requirements are here.
There was a problem hiding this comment.
Right, this is supposed to preserve existing behavior. Thanks for pointing that out!
kubamracek
force-pushed
the
unroll-strcasecmp
branch
from
5ad3e60 to
2b0ff96
Compare
|
@swift-ci please test |
mikeash
approved these changes
Sep 15, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.