Skip to content

[stdlib] Improve set isDisjoint by iterating on smaller set #39263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[stdlib] Improve set isDisjoint by iterating on smaller set #39263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion stdlib/public/core/Set.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,15 @@ extension Set {
/// otherwise, `false`.
@inlinable
public func isDisjoint(with other: Set<Element>) -> Bool {
return _isDisjoint(with: other)
guard !isEmpty && !other.isEmpty else { return true }
let (smaller, larger) =
count < other.count ? (self, other) : (other, self)
for member in smaller {
if larger.contains(member) {
return false
}
}
return true
}

@inlinable
Expand Down