Skip to content

Fix SelectValue for OSSA #39574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Fix SelectValue for OSSA #39574

merged 1 commit into from
Oct 4, 2021

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Oct 4, 2021

Fix two bugs:

  • FirstArgOwnershipForwardingSingleValueInst needs to forward its first operand.

  • select_value needs to be a ForwardedBorrow for all cases and the default.

@atrick
Fix SelectValue for OSSA
99f49d9 
Fix two bugs:

- FirstArgOwnershipForwardingSingleValueInst needs to forward its first operand.

- select_value needs to be a ForwardedBorrow for all cases and the default.
@atrick atrick requested review from gottesmm and meg-gupta October 4, 2021 20:07
@atrick
Copy link
Contributor Author

atrick commented Oct 4, 2021

@swift-ci smoke test

meg-gupta
meg-gupta approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@atrick atrick merged commit 46fd9b3 into swiftlang:main Oct 4, 2021
@atrick atrick deleted the ossa-selectvalue branch October 4, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meg-gupta meg-gupta meg-gupta approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atrick @meg-gupta