Skip to content

[swift-syntax] Don’t pass --filecheck-exec to swift-syntax’s build script #68364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[swift-syntax] Don’t pass --filecheck-exec to swift-syntax’s build script #68364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions utils/swift_build_support/swift_build_support/products/swiftsyntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,7 @@ def test(self, host_target):
llvm_build_dir = os.path.realpath(llvm_build_dir)

self.run_swiftsyntax_build_script(target=host_target,
command='test',
additional_params=[
'--filecheck-exec',
os.path.join(llvm_build_dir,
'bin',
'FileCheck')
])
command='test')

def should_install(self, host_target):
return self.args.install_swiftsyntax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the dependencies in get_dependencies actually needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so. We might not need to list LLVM, LibCXX, LibICU and LLBuild because they are transitive dependencies of Swift / SwiftPM that we don’t explicitly depend upon but I’m not sure if get_dependencies should include these transitive dependencies.

@gottesmm You added these, do you know if we explicitly need to list these dependencies here?

Expand Down