build: Install llvm-ranlib in OSS toolchains
#72212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds `llvm-ranlib` to the list of components installed into the OSS toolchains for macOS and Linux. The `llvm-ranlib` tool is required for WebAssembly builds because system `ranlib` usually cannot recognize Wasm object format. `llvm-ranlib` is just a symlink to `llvm-ar`, so extra space is not a concern.
|
@swift-ci test |
|
@swift-ci build toolchain |
al45tair
approved these changes
Mar 11, 2024
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Mar 30, 2024
llvm-ranlib is now installed in the toolchain, so we can use it instead of the one in the build directory. swiftlang#72212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
llvm-ranlibto the list of components installed into the OSS toolchains for macOS and Linux. Thellvm-ranlibtool is required for WebAssembly builds because systemranlibusually cannot recognize Wasm object format.llvm-ranlibis just a symlink tollvm-ar, so extra space is hopefully not a concern.Without installing the tool, each Swift SDK for WebAssembly needs to build and distribute
llvm-ranlibas a part of the SDK even though the toolchain has the actual code ofllvm-ranlibasllvm-ar.