Skip to content

[6.0] Disable CMake-based Foundation tests #74638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmschonfeld
Copy link
Contributor

Cherry pick of #74589

Explanation: Disables Foundation tests invoked by CMake
Scope: Affects testing of Foundation
Original PR: #74589
Risk: Low - disables tests, does not impact the actual build of the toolchain
Testing: PR testing via swift-ci
Reviewer: @parkera

* Disable old CMake-based Foundation tests

* Remove foundation tests from build-windows-toolchain.bat instead of build.ps1
@jmschonfeld jmschonfeld requested a review from a team as a code owner June 21, 2024 23:10
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld enabled auto-merge (squash) June 21, 2024 23:10
@jmschonfeld jmschonfeld requested a review from bnbarham June 21, 2024 23:22
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we add testing back ASAP :)

@jmschonfeld
Copy link
Contributor Author

Yep we'll be adding it back as soon as we land the new Foundation

@jmschonfeld
Copy link
Contributor Author

@swift-ci please test Linux platform

@jmschonfeld jmschonfeld merged commit 54898ce into swiftlang:release/6.0 Jun 22, 2024
5 checks passed
@jmschonfeld jmschonfeld deleted the disable-foundation-tests-6-0-cherrypick branch July 15, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants