[6.0] Fix two problems with -cross-module-optimization
#74930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-once functions Instead ignore empty global-init-once functions swiftlang#73487 rdar://130041582
…mization In case of cross-module-optimizations it can happen that a private global variable is changed to public, but it's declaration is not available in the module file.
|
@swift-ci test |
tbkka
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-cross-module-optimization: one problem in MandatoryPerformanceOptimizations (it needs to consider empty global-init-once functions) and one problem in the Deserializer (handle the case that for de-serialized globals there might not be a var-declaration available in the module file)-cross-module-optimization-cross-module-optimization#74893