Skip to content

Fix -Wunknown-pragmas warnings with gcc in swift demangling code #75681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

nico
Copy link
Contributor

@nico nico commented Aug 5, 2024

No intended behavior change.

@nico nico requested a review from rjmccall as a code owner August 5, 2024 01:37
nico added a commit to nico/demumble that referenced this pull request Aug 5, 2024
nico added a commit to nico/demumble that referenced this pull request Aug 5, 2024
nico added a commit to nico/demumble that referenced this pull request Aug 5, 2024
nico added a commit to nico/demumble that referenced this pull request Aug 5, 2024
@nico
Copy link
Contributor Author

nico commented Aug 6, 2024

@compnerd Want to bless this one too? IIRC it even modifies lines you touched :)

@compnerd
Copy link
Member

compnerd commented Aug 6, 2024

@swift-ci please test

@nico
Copy link
Contributor Author

nico commented Aug 6, 2024

Linux test output:

2024-08-06 04:06:49.563 swift-corelibs-foundationPackageTests.xctest[13785:70dfa700] httpServer: accept failed: Invalid argument (22)
TestFoundation/TestURLSession.swift:637: error: TestURLSession.test_connectTimeout : XCTAssertEqual failed: ("nil") is not equal to ("Optional(Foundation.URLError.Code.timedOut)") - Task should fail with URLError.timedOut error
2024-08-06 04:06:52.564 swift-corelibs-foundationPackageTests.xctest[13785:70dfa700] httpServer: accept failed: Invalid argument (22)
Test Case 'TestURLSession.test_connectTimeout' failed (3.002 seconds)
...
Test Suite 'TestURLSession' failed at 2024-08-06 04:07:08.747
	 Executed 79 tests, with 13 tests skipped and 1 failure (0 unexpected) in 19.292 (19.292) seconds

I'm gonna go out on a limb and say that that's unrelated to this change :)

What's the process for flakes? Re-run and hope for the best? Look at the output, realize it's non-sensical and just merge? Something else?

@compnerd
Copy link
Member

compnerd commented Aug 6, 2024

@swift-ci please test Linux platform

@nico
Copy link
Contributor Author

nico commented Aug 7, 2024

CI came back green, can someone hit merge? :)

@compnerd compnerd merged commit 30ce1b0 into swiftlang:main Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants