Skip to content

[cxx-interop] Create benchmarks for using std::span in Swift #76245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

susmonteiro
Copy link
Contributor

  • swift-ci linux tests do not support std::span

@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro marked this pull request as ready for review September 9, 2024 10:13
@susmonteiro susmonteiro requested review from egorzhdan and removed request for eeckstein September 9, 2024 10:13
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one minor comment.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 9, 2024
* swift-ci linux tests do not support std::span
@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from dab51ea to 6239c10 Compare September 9, 2024 11:47
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@susmonteiro susmonteiro merged commit 28ac942 into main Sep 9, 2024
4 checks passed
@susmonteiro susmonteiro deleted the susmonteiro/cxx-span-benchmarks branch September 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants