[6.1] Emit reabstraction thunks for implicit conversions between T.TangentType and Optional<T>.TangentType #79540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype and Optional<T>.TangentType (swiftlang#78076) (cherry picked from commit 1e7a1d9)
|
cc @JaapWijnen |
|
@swift-ci Please test |
|
Ping @hamishknight @slavapestov... Any concerns taking this for 6.1? |
|
Closing since we have an official 6.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit reabstraction thunks for implicit conversions between T.TangentType and Optional.TangentType. Resolves a crash from silgen, producing a diagnostic instead.
Affects primarily autodiff code.
Crash in silgen due to missed / failed typecheck #77871
Emit reabstraction thunks for implicit conversions between T.TangentType and Optional<T>.TangentType #78076
Low.
Verified the silgen crash still occurs on the latest
release/6.1snapshot, and the correct diagnostic is emitted using the latestmainsnapshot.@asl @hamishknight @slavapestov