Optimizer: move optimizer bridging code from PassManager.cpp into its own file
#80113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any of the get*() methods are called on the wrong kind of ProtocolConformanceRef, we immediately cast a pointer to an incorrect type, which will most likely cause a crash.
The "abstract conformance is just a ProtocolDecl" assumption is pretty fundamental here, so we have to fudge a bit at the API boundary for now. Eventually, LocalTypeDataKind should just contain a ProtocolConformanceRef instead of duplicating the representation, however this would require fixing various calls to LocalTypeDataKind::forAbstractProtocolWitnessTable() which pass in a ProtocolDecl to pass in a ProtocolConformanceRef instead.
…eWitness The Protocol field isn't really necessary, because the conformance stores the protocol. But we do need the substituted subject type of the requirement, just temporarily, until an abstract conformance stores its own subject type too.
This reverts the problematic parts of fcbebc5 which had caused a lot of unintended fallout, while preserving the actual feature supported by the patch. Before that patch (fcbeb), and after this one, we don't emit members of specialized bound generic types, because these can be reconstructed by substituting the "template parameters" in the unspecialized type. This patch carves out an exception for inline arrays, because DWARF has special support for arrays, which allows debuggers to reason about them without needing special support. rdar://146326633
… own file. The bridging code was in PassManager.cpp only for historical reasons. It's now in OptimizerBridging.cpp. NFC
|
@swift-ci smoke test |
…ormance Fix a few more callers of ProtocolConformanceRef::forAbstract() to pass in a subject type
[Debug Info] Do not emit children of bound generic types
…bridging Optimizer: move optimizer bridging code from `PassManager.cpp` into its own file
eeckstein
requested review from
jckarter,
adrian-prantl,
xymus,
AnthonyLatsis,
hborla,
slavapestov,
xedin and
rjmccall
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridging code was in
PassManager.cpponly for historical reasons. It's now inOptimizerBridging.cpp.NFC