SILGen: Fix if #available for unavailable custom domains in zippered modules
#81767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
rjmccall and
jckarter
as code owners
…d modules. When generating SIL for an `if #available(SomeDomain)` query in code being compiled for a zippered target, the generated code was mis-compiled if `SomeDomain` were disabled at compile time. Empty version ranges need to be handled explicitly by `SILGenFunction::emitZipperedOSVersionRangeCheck()`. SILGen still miscompiles `if #unavailable` queries generally in code compiled for a zippered target (rdar://147929876). Resolves rdar://150888941.
tshortli
force-pushed
the
fix-zippered-custom-availability-queries
branch
from
64150f2 to
4aa516a
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating SIL for an
if #available(SomeDomain)query in code being compiled for a zippered target, the generated code was mis-compiled ifSomeDomainwere disabled at compile time. Empty version ranges need to be handled explicitly bySILGenFunction::emitZipperedOSVersionRangeCheck().SILGen still miscompiles
if #unavailablequeries generally in code compiled for a zippered target (rdar://147929876).Resolves rdar://150888941.