Fix an inliner crash when inlining begin_apply with scoped lifetime dependence #82033
Conversation
meg-gupta
requested review from
atrick
and removed request for
jckarter and
eeckstein
|
@swift-ci test |
There was a problem hiding this comment.
I think this is fine as a short-term fix. A few requests
-
Preemptively file a bug against me with test case for the duplicate diagnostic. We do need to fix that as soon as possible.
-
add a unit test where the token dependency is actually required and check the SIL to ensure that the an inlined dependency exists after inlining that has the same effect as the deleted mark_dependence
-
clarify the comment that commented on here...
| // mark_dependence/mark_dependence_addr may have begin_apply's token result | ||
| // as their operand. This is needed for diagnosing lifetime dependencies for | ||
| // ~Escapable yields. Delete them while inlining the begin_apply since the | ||
| // dependence is also represented by lifetime dependence sources. |
There was a problem hiding this comment.
I think this comment is a little off...
The mark_dependence on the coroutine token represents a dependency on the coroutine context. That is different from a dependency on one of the coroutine parameters. For example, the yielded value may depend on a value created inside the coroutine.
I guess we can assume that inlining the coroutine will expose any dependencies within the coroutine implementation, so we can delete the dependency on the context after inlining, but I haven't investigated that at all. It would be worth adding a unit test for that case that checks the SIL after inlining.
…ependence LifetimeDependenceInsertion inserts mark_dependence on token result of a begin_apply when it yields a lifetime dependent value. When such a begin_apply gets inlined, the inliner can crash because of the remaining uses of the token result. Fix this by inserting mark_dependence on parameter operands that are lifetime dependence sources and deleting the mark_dependence on token results in the inliner. Fixes rdar://151568816
meg-gupta
force-pushed
the
fixinlinercrash
branch
from
6c5c661 to
8396a6d
Compare
|
@atrick Created rdar://153175960 to track removing duplicate diagnostics and made updates to tests and comments. |
|
@swift-ci test |
LifetimeDependenceInsertion inserts mark_dependence on token result of a begin_apply when it yields a lifetime dependent value. When such a begin_apply gets inlined, the inliner can crash because of the remaining uses of the token result.
Fix this by inserting mark_dependence on parameter operands that are lifetime dependence sources and deleting the mark_dependence on token results in the inliner.
Fixes rdar://151568816
Fixes #81595