[AST] Replace type variables and placeholders in original ErrorTypes #82292
Conversation
Turns out we can also get solver-allocated original ErrorTypes through type resolution. Given the original type is only used for printing/debugging, let's just fold away any type variables and placeholders into UnresolvedType (which print as placeholders). This matches what `Solution::simplifyType` does.
|
@swift-ci please test |
| // Match the logic in `Solution::simplifyType` and use UnresolvedType. | ||
| // FIXME: Ideally we'd get rid of UnresolvedType and just use a fresh | ||
| // PlaceholderType, but we don't currently support placeholders with no | ||
| // originators. |
There was a problem hiding this comment.
Just to note that this is indeed the long-term plan, we need to remove UnresolvedType in favor of PlaceholderType
There was a problem hiding this comment.
Maybe we should limit this transformation to solver allocated placeholder types instead of all of them. We could also expand ErrorExpr originator and replace type variables with placeholders that point to ASTNode that their locator simplifies down to...
There was a problem hiding this comment.
Maybe we should limit this transformation to solver allocated placeholder types instead of all of them
I would rather apply the transform consistently to match what we do in Solution::simplifyType, conditionalizing the logic on the allocation arena or originator seems a little odd to me. We should revisit this when we get rid of UnresolvedType though.
We could also expand ErrorExpr originator and replace type variables with placeholders that point to ASTNode that their locator simplifies down to...
Yeah maybe, I don't think there are any ErrorType consumers that currently really care about originators, but maybe that could be useful for debugging?
There was a problem hiding this comment.
Yeah, I was mostly talking long-term as part of UnresolvedType removal :)
Turns out we can also get solver-allocated original ErrorTypes through type resolution. Given the original type is only used for printing/debugging, let's just fold away any type variables and placeholders into UnresolvedType (which print as placeholders). This matches what
Solution::simplifyTypedoes.