[Dependency Scanning] Diagnose an error when only finding incompatible Swift binary modules #82460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
ScanDepsDiagnoseOnlyIncompatibleCandidates
branch
from
f798987 to
0c0f75f
Compare
|
This is a great enhancement Artem! |
artemcm
force-pushed
the
ScanDepsDiagnoseOnlyIncompatibleCandidates
branch
2 times, most recently
from
df01027 to
be6c7ec
Compare
|
@swift-ci test |
artemcm
force-pushed
the
ScanDepsDiagnoseOnlyIncompatibleCandidates
branch
from
be6c7ec to
fa4dce9
Compare
artemcm
requested review from
xymus,
cachemeifyoucan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
artemcm
force-pushed
the
ScanDepsDiagnoseOnlyIncompatibleCandidates
branch
2 times, most recently
from
3dea017 to
3a36c37
Compare
|
@swift-ci test |
|
@swift-ci test macOS platform |
artemcm
force-pushed
the
ScanDepsDiagnoseOnlyIncompatibleCandidates
branch
from
3a36c37 to
60be4db
Compare
|
swiftlang/swift-driver#1943 |
artemcm
force-pushed
the
ScanDepsDiagnoseOnlyIncompatibleCandidates
branch
from
60be4db to
58faf1d
Compare
|
swiftlang/swift-driver#1943 |
…e Swift binary modules When querying a Swift module, the scanner now also keeps track of all discovered candidate binary modules which are not compatible with current compilation. - If a Swift dependency is successfully resolved to a compatible binary module or a textual interface, a warning is emitted for every incompatible binary Swift module discovered along the way. - If a Swift dependency is not resolved, but incompatible module candidates were found, an error is emitted - while it is likely that the scan would fail downstream, it is also possible that an underlying Clang module dependency (with the same name) is successfuly resolved and the Swift lookup failure is ignored, which is still going to lead to failures most of the time if the client code assumes the presence of the Swift overlay module in this scenario. This change refactors common error reporting by the scanner into a 'ModuleDependencyIssueReporter' class, which also keeps track of all diagnosed failed lookups to avoid repeating diagnostics.
artemcm
force-pushed
the
ScanDepsDiagnoseOnlyIncompatibleCandidates
branch
from
58faf1d to
f5530a1
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying a Swift module, the scanner now also keeps track of all discovered candidate binary modules which are not compatible with current compilation.
This change refactors common error reporting by the scanner into a
ModuleDependencyIssueReporterclass, which also keeps track of all diagnosed failed lookups to avoid repeating diagnostics.