[Backtracing][Linux] Fix crash handler for musl. #82624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musl's `clone()` wrapper returns `EINVAL` if you try to use `CLONE_THREAD`, which seems a bit wrong (certainly it is in this particular application, since we *really* don't care whether the thread is a valid C library thread at this point). Also properly support ELF images that are built with a base address other than zero (this typically isn't an issue for dynamically linked programs, as they will be relocated at runtime anyway, but for statically linked binaries it's very common to set the base address to a non-zero value). rdar://154282813
|
@swift-ci Please smoke test |
mikeash
approved these changes
Jun 30, 2025
| } | ||
| imageBase = ImageSource.Address(exactly: minAddr ?? 0)! |
There was a problem hiding this comment.
Is there any benefit to failing gracefully here for values that aren't representable, like minAddr.map { ImageSource.Address(exactly: $0) } ?? 0?
There was a problem hiding this comment.
Not sure. On the one hand, that would stop it crashing in such a case. On the other, I think that's rather unlikely in practice (ImageSource.Address is usually UInt64).
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Musl's
clone()wrapper returnsEINVALif you try to useCLONE_THREAD, which seems a bit wrong (certainly it is in this particular application, since we really don't care whether the thread is a valid C library thread at this point).Also properly support ELF images that are built with a base address other than zero (this typically isn't an issue for dynamically linked programs, as they will be relocated at runtime anyway, but for statically linked binaries it's very common to set the base address to a non-zero value).
rdar://154282813