[ClangImporter] Fix dangling reference. #82708
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LookupOverloadedBinOp stores `Args` for later use, so store the backing array on the stack instead of using a temporary. This fixes a crash that appeared under some build configurations. Related to rdar://154291418
Bigcheese
requested review from
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
Jul 2, 2025
AnthonyLatsis
approved these changes
Jul 2, 2025
|
@swift-ci please test Windows |
Xazax-hun
reviewed
Jul 2, 2025
| @@ -265,7 +265,8 @@ instantiateTemplatedOperator(ClangImporter::Implementation &impl, | |||
| classDecl->getLocation(), clang::OverloadCandidateSet::CSK_Operator, | |||
| clang::OverloadCandidateSet::OperatorRewriteInfo(opKind, | |||
| clang::SourceLocation(), false)); | |||
| clangSema.LookupOverloadedBinOp(candidateSet, opKind, ops, {arg, arg}, true); | |||
| std::array<clang::Expr *, 2> args{arg, arg}; | |||
| clangSema.LookupOverloadedBinOp(candidateSet, opKind, ops, args, true); | |||
There was a problem hiding this comment.
Could you elaborate on where this array gets stored and for how long? Are we storing the array in the candidateSet?
There was a problem hiding this comment.
Yes, it's stored in candidateSet so the lifetime needs to extend to the last use of candidateSet, excluding the destructor.
|
@swift-ci please test windows |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LookupOverloadedBinOpstoresArgsfor later use, so store the backing array on the stack instead of using a temporary.This fixes a crash that appears under some build configurations.
Related to rdar://154291418