wasm-run.py: consistent wasmkit path with build_runtime_with_host_compiler
#83134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host_compiler` When passing `--build-runtime-with-host-compiler` there's no such executable `wasmkit-cli` in the host toolchain, where it's named `wasmkit` when installed. Let's make that consistent to make it work in both cases.
MaxDesiatov
added
test suite
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
kateinoigakukun
requested changes
Jul 18, 2025
MaxDesiatov
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
IIUC it still worked on CI because it picked up |
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
MaxDesiatov
added a commit
to MaxDesiatov/swift
that referenced
this pull request
Jul 21, 2025
MaxDesiatov
added a commit
to MaxDesiatov/swift
that referenced
this pull request
Jul 21, 2025
MaxDesiatov
added a commit
that referenced
this pull request
Jul 22, 2025
wasmswiftsdk.py: consistently apply `build_runtime_with_host_compiler` Following up on #83134 #82949 #82946 #82944. With these changes I'm able to quickly build and test only Wasm Swift SDK without rebuilding the whole toolchain when latest development snapshot is installed, using this invocation: ``` ./swift/utils/build-script --skip-build-benchmarks --release --skip-early-swift-driver \ --skip-build-lldb --skip-build-cmark --skip-build-llvm --skip-build-swift \ --build-runtime-with-host-compiler --build-wasm-stdlib ``` Timing on M4 MacBook Pro: ``` --- Build Script Analyzer --- Build Percentage Build Duration (sec) Build Phase ================ ==================== =========== 43.6% 257.75 Building wasmswiftsdk 20.6% 121.91 Building wasmthreadsstdlib 20.6% 121.78 Building wasmstdlib 5.4% 32.03 Building wasmllvmruntimelibs 3.6% 21.39 Running tests for wasmthreadsstdlib 3.5% 20.91 Running tests for wasmstdlib 2.7% 15.74 Building wasilibc 0.0% 0.04 macosx-arm64-extractsymbols 0.0% 0.04 macosx-arm64-package 0.0% 0.03 merged-hosts-lipo-core 0.0% 0.03 merged-hosts-lipo Total Duration: 591.65 seconds (9m 51s) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing
--build-runtime-with-host-compilerthere's no such executablewasmkit-cliin the host toolchain, where it's namedwasmkitwhen installed. Let's make that consistent to make it work in both cases.