Cleanup diagnostics for deleted or renamed files #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the file is deleted or renamed, remove it from the diagnostic collection. Extract the swift file types to a constant. Issue: swiftlang#1652
plemarquand
approved these changes
Jun 25, 2025
|
Would be nice to add a test for this |
I figured this added a bit of a flake factor as we would have to delete or rename the source file and hope we can undo the action later in the suite. I guess I could add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the file is deleted or renamed, remove it from the diagnostic collection. Extract the swift file types to a constant.
Issue: #1652