-
Notifications
You must be signed in to change notification settings - Fork 80
load packages from workspace-state.json, missing packages can show #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2f5c2bc
fixed local recursive packages don't show
aelam 79313fa
added identifier and fixed name/version in list
aelam e635ee8
fixed editing packages shows well
aelam 6dafdb1
fixed editing package path issue
aelam 9a16288
clean up and enable menu for `swift package edit`
aelam f4ac5c5
clean up
aelam ed5d241
rename getAllPackages
aelam 74b012f
change the way of loading workspaceDependencies
aelam 856b72b
fixed dependency issues
aelam e739f1b
Merge branch 'main' into fix_dependency_list
aelam 58e9086
Update package.json
aelam ce97c15
don't cache dependencies
aelam 58f0bb6
revert some code
aelam 1060f17
revert EditedPackage
aelam 603bbb1
update customTask, fixed watcher
aelam 803567d
resolve dependency graph with recursive swift package describe
aelam 8b72eef
revert unnecessary changes
aelam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -432,11 +432,12 @@ function updateAfterError(result: boolean, folderContext: FolderContext) { | |
const triggerResolvedUpdatedEvent = folderContext.hasResolveErrors; | ||
// set has resolve errors flag | ||
folderContext.hasResolveErrors = !result; | ||
|
||
// if previous folder state was with resolve errors, and now it is without then | ||
// send Package.resolved updated event to trigger display of package dependencies | ||
// send workspace-state.json updated event to trigger display of package dependencies | ||
// view | ||
if (triggerResolvedUpdatedEvent && !folderContext.hasResolveErrors) { | ||
folderContext.fireEvent(FolderEvent.resolvedUpdated); | ||
folderContext.fireEvent(FolderEvent.workspaceStateUpdated); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. only trigger UI updates |
||
} | ||
} | ||
|
||
|
@@ -455,17 +456,17 @@ export function register(ctx: WorkspaceContext) { | |
vscode.commands.registerCommand("swift.openPackage", () => openPackage(ctx)), | ||
vscode.commands.registerCommand("swift.useLocalDependency", item => { | ||
if (item instanceof PackageNode) { | ||
useLocalDependency(item.name, ctx); | ||
useLocalDependency(item.identity, ctx); | ||
} | ||
}), | ||
vscode.commands.registerCommand("swift.editDependency", item => { | ||
if (item instanceof PackageNode) { | ||
editDependency(item.name, ctx); | ||
editDependency(item.identity, ctx); | ||
} | ||
}), | ||
vscode.commands.registerCommand("swift.uneditDependency", item => { | ||
if (item instanceof PackageNode) { | ||
uneditDependency(item.name, ctx); | ||
uneditDependency(item.identity, ctx); | ||
} | ||
}), | ||
vscode.commands.registerCommand("swift.openInWorkspace", item => { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind this change