[pull] swiftwasm-release/5.3 from release/5.3 #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…nt a crash during indexing. locator->getAnchor() may return a null Expr*, but was being passed directly to isa<KeyPathExpr>(..) without a null check in two places. Resovles rdar://problem/63558609
…lang#31968) * [5.3] IRGen: Always eliminate frame pointers of leaf functions Explanation: This change makes it such that we don't emit frame pointers in leaf functions leading to decreased code size and improved performance. Scope: Should not visibly affect Swift programs other than making them faster. Risk: Medium. There might be unknown dependencies on having the frame pointer available in leaf functions. Testing: Unit test added Reviewer: Andrew Trick rdar://20933449 * Fix test * Only use omit the frame pointer on arm64, x86_64 darwin needs it for some its tools * Fix test on linux
…p-indexing-crash [5.3] Fix dynamic member lookup index-while-building crash
MaxDesiatov
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )