Quote inconsistency between env vars in phpunit.xml.dist and .env

[weaverryan]

symfony/recipes#361 created an interesting issue :).

After this change, .env looked like this:

DATABASE_URL='mysql://root:@127.0.0.1:3306/test_maker'

(it used double quotes before). BUT, this broke phpunit.xml.dist, which now looks like this:

<env name="DATABASE_URL" value="'mysql://root:@127.0.0.1:3306/test_maker'"/>

The extra single quotes become part of the value.

I'm proposing that we revert symfony/recipes#361 in symfony/recipes#363.

I'm not sure how to fix this. Sometimes, you do want double-quotes - so you can have \n and other things. But many times, we want the user to have single quotes. Perhaps we should always use single quotes in the recipes? And the user can change to double if they want? I could open a PR - I just wasn't sure at first.

[fabpot]

Indeed, 361 is wrong. Flex (the latest versions) manages the escaping automatically depending on the context. So, there is nothing to "fix". If that does not work correctly, then it's a bug that needs to be corrected.

[stof]

Well, the thing is, at the time Flex sets the default value for the DATABASE_URL, it will consider that the escaping is unnecessary (because the default value does not have special chars in it). But when people change their .env file to put their actual credentials, they may face issues with the $ in their password, which gets expanded as a variable.

Btw, I'm not even sure Flex properly escapes env variables containing a $

[stof]

An option could be to have Flex always single-quoting values in .env, and letting people wanting variable expansion unquote values (or switch to double quote), instead of breaking things for all people not even knowing that Dotenv performs such expansion.

[weaverryan]

I was thinking the same thing

[nicolas-grekas]

Use .env.test instead, see symfony/recipes#481